Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering artifacts in tasks that only allow flight mode #3783

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Feb 14, 2019

Objects that should only be visible in orthogonal mode were by default always visible after their initialization. They are hidden when stopping orthogonal mode, but that didn't happen if orthogonal mode was never active.

I fixed this by hiding all those objects after their initialization, they'll be made visible when orthogonal mode is started anyways.

If you have a better name, for start/stopPlaneMode, please let me know :)

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create a task type that only allow flight mode and create a task with that task type.
  • Request said task and open it - There should be no rendering artifacts visible (see screenshot in issue).
  • Open an explorative tracing (which starts in orthogonal mode by default). Everything should be visible as before.

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@daniel-wer daniel-wer merged commit 9359a9f into master Feb 18, 2019
@daniel-wer daniel-wer deleted the fix-flight-only branch February 18, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering artifacts in tasks that only allow flight mode
2 participants